Repository navigation
Conversation
Contributor
Author
|
Follow-up verification complete. Local lint, build, and test re-run on 503defc pass with no new lint violations. The flaky Mobile e2e failure was re-run and now passes, so every CI check is green and the merge state is CLEAN. This PR only needs a human approving review now. No new slice was started this run, per the one-agent-PR rule. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds daily aggregation for Apple Health exports. A new Foundation-only DailyHealthSummary value type holds one day of steps, active and basal energy, distance, average and resting heart rate, body mass, and sleep duration, and HealthExport.dailySummaries(calendar:) groups the parsed records by start-of-day and returns summaries sorted by day.
Part of #6. Closes #32.
How it was verified:
mise run lint- no violations in the added files. Repo total stays at the pre-existing baseline (503 violations, 11 serious across 126 files, all in existing files). The lint task reports failure on that baseline, same as on origin/main before this change.mise run build- passed.mise run test- passed, 133 tests with 0 failures. The 9 new DailyHealthSummaryTests are listed below.mise run ios:build:devandmise run ios:test:uiwere not run. Nothing user-facing changed; this slice is core aggregation logic only.Proof, terminal capture from
mise run testfiltered to the new suite:Each test name states what it shows. Together they cover grouping and sorting by day, summing steps with kilojoule and kilometre normalisation, averaging heart rate, picking the latest resting heart rate and body mass of the day, summing sleep stages, keeping missing kinds nil instead of zero, skipping records without a start date, an empty export, an end-to-end run through HealthExportParser, and a Codable round-trip.
Reviewer notes:
Follow-up verification (2026-11-08, later run):
mise run lintstill 503 violations with none in the two added files,mise run buildpassed,mise run testpassed with all 9 DailyHealthSummaryTests green.